Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

[release] bump 7.9 branch to 7.9.1-SNAPSHOT#791

Merged
3 commits merged into7.9from
unknown repository
Aug 26, 2020
Merged

[release] bump 7.9 branch to 7.9.1-SNAPSHOT#791
3 commits merged into7.9from
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 18, 2020

This PR bump chart version and Docker images used to 7.9.1-SNAPSHOT to test 7.9.1 development version

See New branching model for more details.

This PR bump chart version and Docker images used to 7.9.1-SNAPSHOT to test 7.9.1 development version

See [New branching model](https://github.com/elastic/helm-charts/blob/master/BREAKING_CHANGES.md#new-branching-model) for more details.
@ghost ghost requested a review from mgreau August 18, 2020 22:25
@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 20, 2020

At least partial success this time:
image

@jmlrt jmlrt self-requested a review August 25, 2020 15:48
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lines that shouldn't be changed. The bumper script need to be reworked to prevent this.

Comment thread elasticsearch/examples/kubernetes-kind/README.md Outdated
Comment thread elasticsearch/examples/upgrade/README.md Outdated
Comment thread elasticsearch/examples/upgrade/README.md Outdated
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that I forgot to document that Elasticsearch API add -SNAPSHOT to the version while the other products don't do it 😭

Comment thread elasticsearch/examples/default/test/goss.yaml Outdated
Comment thread elasticsearch/examples/oss/test/goss.yaml Outdated
Comment thread elasticsearch/examples/upgrade/test/goss.yaml Outdated
@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Aug 26, 2020

@ygel, you'll also need to merge origin/7.9 on your branch to get #798 which is required to fix CI build.

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 26, 2020

🎉

10:15:04 Finished: SUCCESS

@ghost ghost requested a review from jmlrt August 26, 2020 15:32
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Aug 26, 2020

We need to find a way to prevent or document the manual changes from 3d6ab1d

@ghost ghost merged commit e1b0ad9 into elastic:7.9 Aug 26, 2020
@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 26, 2020

please don't delete my 7.9 branch on the fork though :)

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant